Conversation
adfee4b to
09f359d
Compare
|
I will change to draft for now and we can reopen when we want to merge it - that is when we know in which version it will be added. |
d4c00a0 to
6e0cde7
Compare
rfc2822
left a comment
There was a problem hiding this comment.
I think it will finally be time 😄
As I understand it, the basic idea is to check/update the push distributor whenever the PushRegistrationWorker is run, instead of setting it explicitly from the UI.
This sounds good to me! However some notes.
(Also please fix conflicts)
There was a problem hiding this comment.
I think this code should go to a seperate PushDistributorManager, because it's not related to the task of updating the subscriptions.
One class should only do one thing:
PushDistributorManager→ manage push distributorPushRegistrationManager→ manage actual subscriptions
The same applies to the existing PushRegistrationManager.setPushDistributor(), which should also be moved to PushDistributorManager.
Then the PushRegistrationWorker could
pushDistributorManager.update()→ make sure distributor is correct and set up,pushRegistrationManager.update()→ update subscriptions with selected push distributor.
# Conflicts: # app/src/ose/kotlin/at/bitfire/davdroid/di/OseFlavorModule.kt
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
|
As agreed on the meeting, FCM pre-selection for gplay variant is kept. So this should be ready for now. We can keep it improving later (actual distributor pinging to make sure it's available) Note: The gplay preference should be established on the private repo |
Purpose
See #1737, but basically, Push is basically stable enough to at least select a distributor by default.
In any case, if one doesn't trust it, the server admin should simply not install support for push on the server, and the distributor will be unused.
Short description
DistributorPreferences. It contains a list of package names which will define what the preference for each distributor is.DistributorPreferencesimplementation.We still have to add the individual implementations for each flavor on bitfireAt/davx5.
Checklist