Refactor: Move TxTemplate types and logic to bdk_testenv (Fixes #1936)#2122
Open
varunnaikr wants to merge 1 commit intobitcoindevkit:masterfrom
Open
Refactor: Move TxTemplate types and logic to bdk_testenv (Fixes #1936)#2122varunnaikr wants to merge 1 commit intobitcoindevkit:masterfrom
varunnaikr wants to merge 1 commit intobitcoindevkit:masterfrom
Conversation
Author
|
Hi, I have opened a PR for this issue. PR: #2122 |
va-an
suggested changes
Feb 21, 2026
va-an
left a comment
va-an
left a comment
There was a problem hiding this comment.
It looks like this PR only covers part of the issue - the TxTemplate code was copied to bdk_testenv but not removed from the original location, and steps 2-4 from the issue (using Cow<'static, B>, redoing benchmarks, helper methods) are not addressed yet.
Would you consider closing this or converting it to a draft until it's more complete?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Notes to the reviewers
Changelog notice
Checklists
All Submissions:
New Features:
Bugfixes: