chore(core)!: rename SyncResult to SyncResponse

[oleonardolima]

fixes #1647

Description

As mentioned in #1647 issue, the usage of Result in Rust is conventionally meant to be an enum type with error variant, and it's appropriate here.

It should be SyncResponse instead, as it's the most appropriate alongside the other types SyncRequest and SyncProgress already being used.

Notes to the reviewers

Changelog notice

• Change bdk_core::spk_client's SyncResult to SyncResponse.

Checklists

All Submissions:

• I've signed all my commits
• I followed the contribution guidelines
• I ran cargo fmt and cargo clippy before committing

New Features:

• I've added tests for the new feature
• I've added docs for the new feature

Bugfixes:

• This pull request breaks the existing API
• I've added tests to reproduce the issue which are now passing
• I'm linking the issue being fixed by this PR

[notmandatory]

ACK 1411cb8

Looks good, all SyncResults renamed.

[ValuedMammal]

Would it make sense to apply the same reasoning to FullScanResult by renaming it to FullScanResponse?

[oleonardolima]

Would it make sense to apply the same reasoning to FullScanResult by renaming it to FullScanResponse?

Good point! I think it does make sense, added a new commit with the changes so I can either squash it or drop it depending on other opinions.

[notmandatory]

reACK 3b03c7b