Skip to content

fix(core): Fix checkpoint Drop stack overflow #1731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
notmandatory merged 2 commits into from
Nov 21, 2024
Merged

fix(core): Fix checkpoint Drop stack overflow #1731

notmandatory merged 2 commits into from
Nov 21, 2024

Conversation

@LLFourn
Copy link
Collaborator

@LLFourn LLFourn commented Nov 18, 2024

Fixes #1634

This needs a test that demonstrates the issue is fixed. I was hoping @ValuedMammal could do that for me.

@LLFourn LLFourn mentioned this pull request Nov 18, 2024
Closed
@notmandatory notmandatory added bug Something isn't working module-blockchain labels Nov 19, 2024
@notmandatory notmandatory added this to the 1.0.0-beta milestone Nov 19, 2024
@ValuedMammal
test(core): test Drop implementation of CPInner
2df5861 
Check that dropping `CheckPoint` does not cause nasty behavior
by creating a large linked list in memory and then destroying it.
@ValuedMammal
Copy link
Collaborator

ValuedMammal commented Nov 19, 2024

Thanks @LLFourn

ValuedMammal
ValuedMammal approved these changes Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@ValuedMammal ValuedMammal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self-ACK 2df5861

@luisschwab
Copy link
Member

luisschwab commented Nov 20, 2024

ACK 67e1dc3

notmandatory
notmandatory approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 2df5861

@notmandatory notmandatory merged commit d8c8afe into bitcoindevkit:master Nov 21, 2024
20 checks passed
@notmandatory notmandatory mentioned this pull request Dec 11, 2024
Closed
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@notmandatory notmandatory notmandatory approved these changes

@ValuedMammal ValuedMammal ValuedMammal approved these changes

Assignees

@ValuedMammal ValuedMammal

Labels

bug Something isn't working module-blockchain

Projects

BDK Wallet
Archived in project

Milestone

1.0.0-beta

Development

Successfully merging this pull request may close these issues.

example_bitcoind_rpc_polling sync command ends with stack overflow

4 participants

@LLFourn @ValuedMammal @luisschwab @notmandatory