Skip to content

Check time when persisting in rusqlite impl #1730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
notmandatory merged 1 commit into from
Nov 21, 2024
Merged

Check time when persisting in rusqlite impl #1730

notmandatory merged 1 commit into from
Nov 21, 2024

Conversation

@rustaceanrob
Copy link
Contributor

@rustaceanrob rustaceanrob commented Nov 18, 2024

Closes #1713

Any implementation overflowing the i64 type would be clearly faulty, so I just pass up the error if the conversion fails.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@notmandatory notmandatory added module-database audit Suggested as result of external code audit labels Nov 19, 2024
@notmandatory notmandatory added this to the 1.0.0-beta milestone Nov 19, 2024
notmandatory
notmandatory approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 8ec9c0a

oleonardolima
oleonardolima approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 8ec9c0a

@notmandatory notmandatory merged commit b777396 into bitcoindevkit:master Nov 21, 2024
20 checks passed
@rustaceanrob rustaceanrob deleted the sql-11-18 branch November 21, 2024 03:30
@notmandatory notmandatory mentioned this pull request Dec 11, 2024
Closed
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@notmandatory notmandatory notmandatory approved these changes

@oleonardolima oleonardolima oleonardolima approved these changes

Assignees

@rustaceanrob rustaceanrob

Labels

audit Suggested as result of external code audit module-database

Projects

BDK Wallet
Archived in project

Milestone

1.0.0-beta

Development

Successfully merging this pull request may close these issues.

Sqlite: check last_seen timestamp

3 participants

@rustaceanrob @notmandatory @oleonardolima