Skip to content

Type constraint on list canonical tx #1724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ValuedMammal merged 1 commit into from
Nov 18, 2024
Merged

Type constraint on list canonical tx #1724

ValuedMammal merged 1 commit into from
Nov 18, 2024

Conversation

@rustaceanrob
Copy link
Contributor

@rustaceanrob rustaceanrob commented Nov 16, 2024

Closes #1690

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@notmandatory notmandatory added module-blockchain audit Suggested as result of external code audit labels Nov 18, 2024
@notmandatory notmandatory added this to the 1.0.0-beta milestone Nov 18, 2024
ValuedMammal
ValuedMammal approved these changes Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@ValuedMammal ValuedMammal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 2db98ba

@ValuedMammal ValuedMammal merged commit 3bc45b5 into bitcoindevkit:master Nov 18, 2024
20 checks passed
@rustaceanrob rustaceanrob deleted the list-canonical-11-16 branch November 18, 2024 17:45
@notmandatory notmandatory mentioned this pull request Dec 12, 2024
Closed
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ValuedMammal ValuedMammal ValuedMammal approved these changes

Assignees

@rustaceanrob rustaceanrob

Labels

audit Suggested as result of external code audit module-blockchain

Projects

BDK Wallet
Archived in project

Milestone

1.0.0-beta

Development

Successfully merging this pull request may close these issues.

Add Error = Infallible to list_canonical_txs

3 participants

@rustaceanrob @ValuedMammal @notmandatory