chore(deps): bump hashbrown to v0.14.5

[tvolk131]

Bump hashbrown to v0.15

I ran cargo build-all-features and cargo test-all-features locally for the core crate with no issues. Here's the output for the former:

cargo build-all-features

    Building crate=bdk_core features=[]
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.04s
    Building crate=bdk_core features=[hashbrown]
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.04s
    Building crate=bdk_core features=[serde]
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.05s
    Building crate=bdk_core features=[std]
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.04s
    Building crate=bdk_core features=[hashbrown,serde]
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.04s
    Building crate=bdk_core features=[hashbrown,std]
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.04s
    Building crate=bdk_core features=[serde,std]
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.04s
    Building crate=bdk_core features=[hashbrown,serde,std]
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.04s

The relevant changelog can be found between here and here

The only notable breaking change I found was that the MSRV was bumped to v1.63. However, this is the same MSRV as we already use, so it's not a breaking change for us.

[notmandatory]

Sorry about the force pushes, I committed my suggestion instead of closing it. But at least this give the branch a chance to run with the fixed hashbrown dependency.

Looks like hashbrown team doesn't want to fix this and Tokio pinned it in their CI and readme. We can do the same for this PR. Let me know if you want me to push a commit with those changes.

[tvolk131]

Let me know if you want me to push a commit with those changes.

Pushed! Looks like the only feature needed is default-hasher. I re-ran cargo build-all-features and everything's passing locally.

[oleonardolima]

utACK eba1dd0

It's failing on CI at the MSRV step, you'll need to pin it to 0.15.0 here and update the README.md as well.

[notmandatory]

For some reason getting errors with hashbrown pinned to 0.15.0 for MSRV 1.63.0, also reproducible locally:

---- test_into_tx_graph stdout ----
thread 'test_into_tx_graph' panicked at 'a failure ordering can't be stronger than a success ordering', /rustc/4b91a6ea7258a947e59c6522cd5898e7c0a6a88f/library/core/src/sync/atomic.rs:2700:18
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

---- tx_can_become_unconfirmed_after_reorg stdout ----
thread 'tx_can_become_unconfirmed_after_reorg' panicked at 'a failure ordering can't be stronger than a success ordering', /rustc/4b91a6ea7258a947e59c6522cd5898e7c0a6a88f/library/core/src/sync/atomic.rs:2700:18

[notmandatory]

I force pushed a commit to only bump hashbrown to 0.14.5 and disable default features, building and testing for MSRV looks like it's working now. EDIT: with this version I have to leave default features on.

[tnull]

EDIT: with this version I have to leave default features on.

No, I believe you simply need to enable ahash as a default hasher, although inline-more probably also makes sense to leave enabled.

So

hashbrown = { version = "0.14.5", optional = true, default-features = false, features = ["ahash", "inline-more"] }

works for me.

[notmandatory]

EDIT: with this version I have to leave default features on.

No, I believe you simply need to enable ahash as a default hasher, although inline-more probably also makes sense to leave enabled.

@tnull thanks for testing it out, I pushed your suggestion and CI passing so all good. Just FYI the only default feature not included is:

allocator-api2: Enables support for allocators that support allocator-api2.

[tvolk131]

Thanks for updating and testing this guys! Is there anything else needed here, or is this good to merge?

[notmandatory]

ACK 52fa540

[notmandatory]

@tvolk131 I was just giving anyone else interested a chance to comment, but looks good to me so I'll merge it. Thanks for the suggestion to do this version bump.