Skip to content

Comments

feat: Expose miniscript has_wildcard and sanity_check#945

Merged
thunderbiscuit merged 1 commit intobitcoindevkit:masterfrom
ItoroD:miniscript-methods
Feb 19, 2026
Merged

feat: Expose miniscript has_wildcard and sanity_check#945
thunderbiscuit merged 1 commit intobitcoindevkit:masterfrom
ItoroD:miniscript-methods

Conversation

@ItoroD
Copy link
Collaborator

@ItoroD ItoroD commented Feb 10, 2026

Description

Adding these based off of #687

Notes to the reviewers

Documentation

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing
  • I've added a changelog in the next release tracking issue (see example)
  • I've linked the relevant upstream docs or specs above

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

@ItoroD ItoroD changed the title feat: Expose wildcard and sanity checks feat: Expose miniscript wildcard and sanity checks Feb 10, 2026
@ItoroD ItoroD changed the title feat: Expose miniscript wildcard and sanity checks feat: Expose miniscript has_wildcard and sanity_check Feb 10, 2026
@ItoroD
Copy link
Collaborator Author

ItoroD commented Feb 10, 2026

I think the sanity method check is great! I wonder what other kinds of things it could catch.

@reez
Copy link
Collaborator

reez commented Feb 18, 2026

nice addition. are you thinking of adding test coverage for has_wildcard too or are you thinking its not needed? just wondering is all, not a huge blocker or anything

@ItoroD
Copy link
Collaborator Author

ItoroD commented Feb 19, 2026

nice addition. are you thinking of adding test coverage for has_wildcard too or are you thinking its not needed? just wondering is all, not a huge blocker or anything

Yes, I thought it wasn't worthy enough to have its own method 😁

I do not mind adding it.

@ItoroD ItoroD force-pushed the miniscript-methods branch from 7f5ba02 to 16a6da8 Compare February 19, 2026 07:58
@reez
Copy link
Collaborator

reez commented Feb 19, 2026

Yes, I thought it wasn't worthy enough to have its own method 😁

that's what I assumed just wanted to check 👍 all good and already approved regardless

Copy link
Member

@thunderbiscuit thunderbiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK 16a6da8. @ItoroD can you add a changelog entry as well into the changelog file?

Also thanks for the little tests! Makes it easy to undersand the shape of the new APIs when you see them in action.

@thunderbiscuit
Copy link
Member

Mmm I'm sending mixed messages 😆. I ACK'ed but also requested changes sorry. I'll merge once you add the changelog entry!

@ItoroD
Copy link
Collaborator Author

ItoroD commented Feb 19, 2026

Tested ACK 16a6da8. @ItoroD can you add a changelog entry as well into the changelog file?

Will do.

@ItoroD ItoroD force-pushed the miniscript-methods branch from 16a6da8 to 59934a0 Compare February 19, 2026 16:41
@ItoroD ItoroD force-pushed the miniscript-methods branch from 59934a0 to aa3f2a2 Compare February 19, 2026 16:50
@thunderbiscuit thunderbiscuit merged commit aa3f2a2 into bitcoindevkit:master Feb 19, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants