feat: Expose miniscript has_wildcard and sanity_check#945
feat: Expose miniscript has_wildcard and sanity_check#945thunderbiscuit merged 1 commit intobitcoindevkit:masterfrom
has_wildcard and sanity_check#945Conversation
has_wildcard and sanity_check
|
I think the sanity method check is great! I wonder what other kinds of things it could catch. |
|
nice addition. are you thinking of adding test coverage for |
Yes, I thought it wasn't worthy enough to have its own method 😁 I do not mind adding it. |
7f5ba02 to
16a6da8
Compare
that's what I assumed just wanted to check 👍 all good and already approved regardless |
|
Mmm I'm sending mixed messages 😆. I ACK'ed but also requested changes sorry. I'll merge once you add the changelog entry! |
16a6da8 to
59934a0
Compare
59934a0 to
aa3f2a2
Compare
Description
Adding these based off of #687
Notes to the reviewers
Documentation
https://docs.rs/miniscript/latest/miniscript/descriptor/enum.Descriptor.html#method.has_wildcard
https://docs.rs/miniscript/latest/miniscript/descriptor/enum.Descriptor.html#method.sanity_check
bdk_walletbitcoinuniffiOther:
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features: