Make a runtime environment for DNS for Kyoto#814
Merged
thunderbiscuit merged 1 commit intobitcoindevkit:masterfrom Jul 30, 2025
Merged
Make a runtime environment for DNS for Kyoto#814thunderbiscuit merged 1 commit intobitcoindevkit:masterfrom
thunderbiscuit merged 1 commit intobitcoindevkit:masterfrom
Conversation
Collaborator
Author
|
Tested locally with: let peers = await client.lookupHost(hostname: "seed.bitcoin.sprovoost.nl")In the |
reez
approved these changes
Jul 28, 2025
The `lookup_host` function requires a `tokio` runtime to execute, but since it is outside of the `Node`, this function panics when called. Add a runtime, which is essentially an OS thread in this context, to complete the call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
lookup_hostfunction requires atokioruntime to execute, but since it is outside of theNode, this function panics when called. Add a runtime, which is essentially an OS thread in this context, to complete the call.Notes to the reviewers
In the future I could potentially find a more elegant way to do this, but this call should be relatively short and only consume a single thread.
Changelog notice
lookup_hostonCbfClientChecklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
Bugfixes: