feat: Add from_unsigned_tx to Psbt#802
Merged
reez merged 1 commit intobitcoindevkit:masterfrom Jul 9, 2025
Merged
Conversation
Collaborator
Author
Collaborator
ItoroD
force-pushed
the
expose-from-unsigned-tx
branch
3 times, most recently
from
9f59c1b to
45494d3
Compare
ItoroD
force-pushed
the
expose-from-unsigned-tx
branch
from
45494d3 to
5dd6863
Compare
Collaborator
Author
|
rebased! |
reez
reviewed
Jul 9, 2025
| /// | ||
| /// If transactions is not unsigned. | ||
| #[uniffi::constructor] | ||
| pub(crate) fn from_unsigned_tx(tx: Arc<Transaction>) -> Result<Arc<Psbt>, PsbtError> { |
Collaborator
There was a problem hiding this comment.
👍 nice, follows existing pattern for return type of similar methods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allows you to create a Psbt from an unsigned transaction.
Changelog notice
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features: