sim-cli/refactor: pass clock into create_simulation_with_network #292
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If using SimLN as a library, you may want to use the sped up simulation clock in other places. Pass the clock into create_simulation_with_network so that it can be created (and used) externally, and the helper function just sets up the simulation using the clock it is provided.
An alternative approach to this would be to make the Simulation::clock pub, but the downside of this is that you can hit circular dependencies