Secure random number generation. #35
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
crypto.randomInt(); all other JS platforms are compatible with the defaultRandom.secure().Tested with
dart test -p vm,chrome,node -c kernel,dart2js,dart2wasm test/random/random_test.dartChanges
NodeRandomas an implementation ofRandomfor NodeJS.nextInt(max)draws 32-bit values from Node crypto, supports max ∈ [1, 2^32].secureRandom()usesRandom.secure()for web browsers, andNodeRandomfor Node.js.$generateSeed()delegates tosecureRandom()._hashGeneratorNotes