Conversation
|
This issue is stale because it has been open 180 days with no activity. |
github-actions
bot
added
the
stale
…eakage in hgvs.utils.context
|
This issue is stale because it has been open 180 days with no activity. |
github-actions
bot
added
the
stale
github-actions
bot
removed
the
stale
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
| return { | ||
| "match_on": ["method", "uri"], | ||
| "record_mode": os.environ.get("VCR_RECORD_MODE", "new_episodes"), | ||
| "record_mode": os.environ.get("VCR_RECORD_MODE", "none"), |
There was a problem hiding this comment.
I'm wondering if in CI we should set the mode to none and have new_episodes be the default for dev?
There was a problem hiding this comment.
I'd prefer to keep this change. The rationale is that most changes probably won't need new testing data, and it's good to make developers aware of code that does require new testing data.
Co-authored-by: Kori Kuzma <korikuzma@gmail.com>
3 participants
This PR migrates hgvs to the new python packaging.
Note: In order to get tests to pass, I also had to:
To test UX, please:
rm -fr venv .venvmake devreadymake test