Skip to content

Changes examples #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
lukas-stelzl wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Changes examples #5

lukas-stelzl wants to merge 2 commits into from

Conversation

@lukas-stelzl
Copy link
Contributor

@lukas-stelzl lukas-stelzl commented Nov 1, 2018

  1. The conformer_refinement notebook is about refining weights of structures rather than spin-label positions? Is this correct? If added some text to be more explicit about this, if this is true you can just accept the pull-request.

Minor:
2. Adding links and a bit of text to the main notebook for J. Phys. Chem. Lett. paper.

@lukas-stelzl
Making it explicit that in conformer_refinement we are dealing with r…
3c2c9e7 
…elative weights of protein structures rather than refinement of spin-label positions.
@lukas-stelzl
Small additions to the notebook which contains the key computations o…
548490d 
…f Reichel et al. 2018.
@lukas-stelzl
Copy link
Contributor Author

lukas-stelzl commented Nov 2, 2018

@katrinr I would merge now, so we can make further changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@katrinr katrinr Awaiting requested review from katrinr

@jkoefinger jkoefinger Awaiting requested review from jkoefinger

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lukas-stelzl