Added support for fifos and sockets (#42) #204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgree
requested changes
Aug 25, 2025
Contributor
mgree
left a comment
mgree
left a comment
There was a problem hiding this comment.
Nearly there! A few nits, but mostly just the test fix and the find_upperdir_changes/process_changes fix.
| AUTO_CFLAGS="" | ||
| fi | ||
| AUTO_CPPFLAGS="" | ||
| AUTO_CPPFLAGS="" |
Contributor
There was a problem hiding this comment.
This should go now, since we've set it unconditionally above.
Contributor
There was a problem hiding this comment.
I think this comment is still active---no need to set AUTO_CPPFLAGS here.
mgree
reviewed
Dec 26, 2025
Contributor
|
I think just the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for fifos and sockets for try. Added test cases in all-commit-cases.sh for fifos and sockets as well. Added make-socket.c for all-commit-cases.sh.