Skip to content

fix(cli): clean up deployment url output #2960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matthewvolk merged 2 commits into from
Mar 30, 2026
Merged

fix(cli): clean up deployment url output #2960

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f1e7857
fix(cli): clean up deployment url output
matthewvolk Mar 30, 2026
b736348
fix(cli): fix lint warnings and update test expectations
matthewvolk Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/catalyst/src/cli/commands/deploy.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ describe('deployment and event streaming', () => {
'Fetching...',
'Processing...',
'Finalizing...',
'Deployment completed successfully.\n',
'Deployment completed successfully.',
]);
});

Expand Down Expand Up @@ -234,7 +234,7 @@ describe('deployment and event streaming', () => {
'Fetching...',
'Processing...',
'Finalizing...',
'Deployment completed successfully.\n',
'Deployment completed successfully.',
]);

expect(consola.warn).toHaveBeenCalledWith(
Expand Down
8 changes: 5 additions & 3 deletions packages/catalyst/src/cli/commands/deploy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import AdmZip from 'adm-zip';
import { Command, Option } from 'commander';
import { colorize } from 'consola/utils';
import { access, readdir, readFile } from 'node:fs/promises';
import { join } from 'node:path';
import yoctoSpinner from 'yocto-spinner';
Expand Down Expand Up @@ -289,7 +290,6 @@ export const getDeploymentStatus = async (
}

if (data.deployment_url) {
console.log(data.deployment_url);
deploymentUrl = data.deployment_url;
}
});
Expand All @@ -298,10 +298,12 @@ export const getDeploymentStatus = async (
done = streamDone;
}

spinner.success('Deployment completed successfully.\n');
spinner.success('Deployment completed successfully.');

if (deploymentUrl) {
consola.success(`View your deployment at: ${deploymentUrl}`);
const url = deploymentUrl.startsWith('https://') ? deploymentUrl : `https://${deploymentUrl}`;

consola.success(`View your deployment at: ${colorize('blue', url)}`);
}
};

Expand Down
Loading