feat: add propagate with bbox as option and add more metrics (Closes #11) #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added an Evaluator class to compute various segmentation metrics.. - Updated MedSAM3DInferenceConfig to include a list of evaluation metrics. - Adjusted the inference logic to utilize the new evaluation metrics for reporting results.
JoshuaSiraj
changed the title
Closed
strixy16
requested changes
Oct 31, 2025
| default=True, | ||
| description="Whether to propagate the mask with the bounding box.", | ||
| propagate_with_gt: bool = Field( | ||
| default=False, |
Collaborator
Author
There was a problem hiding this comment.
This is using the ground truth not bbox
Collaborator
There was a problem hiding this comment.
Do we save out enough details to run the evaluator without rerunning all of MedSAM?
Collaborator
Author
There was a problem hiding this comment.
The prediction gets saved so yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.