Display colored favicon to indicate current test results#139
Open
cjohansen wants to merge 1 commit intobhauman:masterfrom
Open
Display colored favicon to indicate current test results#139cjohansen wants to merge 1 commit intobhauman:masterfrom
cjohansen wants to merge 1 commit intobhauman:masterfrom
Conversation
When devcards is running tests, display a red favicon when any test on the current page is failing, and a green one when all currently rendered tests are passing.
Owner
|
this is pretty rad, have you tried it in different browsers? |
Author
|
Since you ask, I tried a few more 😁 Seems it doesn't sit well with Safari. I can look into that tomorrow (it's bedtime over here in Norway) and see if I can fix it. Works in Chrome and Firefox on OSX. |
Owner
|
thanks for checking into it, working on chrome and firefox is probably good
enough
…On Wed, Jun 6, 2018 at 1:49 PM, Christian Johansen ***@***.*** > wrote:
Since you ask, I tried a few more 😁 Seems it doesn't sit well with
Safari. I can look into that tomorrow (it's bedtime over here in Norway)
and see if I can fix it. Works in Chrome and Firefox on OSX.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#139 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAAKQOUqolulq9hoiUR6Tv72UvD-CGN6ks5t6EBSgaJpZM4UdSZJ>
.
|
Author
|
I looked into it some more. It appears Safari doesn't do favicons on tabs at all, only for pinned tabs. For some reason, these favicons don't display even on pinned tabs in Safari. Honestly, I don't use Safari that actively for development, and thus am not super motivated to figure it out. Maybe Firefox and Chrome (and Brave, btw) can be a good start, and then Safari favicons can be an improvement up for grabs? :) |
Owner
|
I'm still planning on merging this, I just need to kick the tires a bit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I recently saw your first talk showcasing figwheel, and I really liked the favicon trick you employed on running tests with it. So I found a gist of yours and added the feature to devcards when running tests.
When devcards is running tests, it will keep tabs on all tests currently rendered on the page. If there are any failures, it adds a red favicon, otherwise it adds a green favicon.