Fix UTF-8 character handling in name truncation#116
Merged
Conversation
Fixed panic when truncating organization names containing multi-byte UTF-8 characters (e.g., Arabic, Chinese, emoji). Changed from byte-based to character-based string operations. Changes: - Fixed truncate_name to use chars().count() and chars().take() instead of byte-based slicing that could panic on multi-byte characters - Moved utils module from lens::utils to crate-level utils for better organization (eliminates misleading structure) - Added tests for Arabic, mixed scripts, and emoji character handling Fixes #115
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed panic when truncating organization names containing multi-byte UTF-8 characters (Arabic, Chinese, emoji, etc.).
Problem
The
truncate_namefunction used byte-based string slicing (&name[..n]) which panics when the slice falls in the middle of a multi-byte UTF-8 character.Example from issue #115:
Solution
name.chars().count()andname.chars().take(n).collect()utilsmodule fromlens::utilsto crate-level for better organizationChanges
truncate_nameinsrc/utils.rsto handle multi-byte characterslens/utils.rs→src/utils.rsTesting
All tests pass:
Closes #115