Skip to content

Conversation

@bghira
Copy link
Owner

@bghira bghira commented Jan 26, 2026

Closes #2470

This pull request addresses issues with handling conditioning data in the batch preparation process, particularly when dealing with nested lists that can arise from varying image aspect ratios. It also makes minor adjustments to training example handling and test mocks for improved robustness.

Batch conditioning robustness:

  • Added logic to flatten nested lists in the prepare_batch_conditions method of model.py, ensuring consistent handling of conditioning data even when input images have different aspect ratios.

Training example handling:

  • Modified the _pop_training_example_for_path function in collate.py to pass an explicit is_conditioning flag when the conditioning type is "reference_loose", improving clarity and correctness in downstream processing.

Test improvements:

  • Updated the mock for check_latent_shapes in test_collate.py to accept arbitrary keyword arguments, preventing potential errors during testing.

@bghira bghira merged commit 8bfad36 into main Jan 26, 2026
2 checks passed
@bghira bghira deleted the bugfix/2470 branch January 26, 2026 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

edit model support for mixed-aspect reference inputs

2 participants