(#2470) multi-aspect input conditioning for kontext, flux2 and qwen edit #2497
+13
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2470
This pull request addresses issues with handling conditioning data in the batch preparation process, particularly when dealing with nested lists that can arise from varying image aspect ratios. It also makes minor adjustments to training example handling and test mocks for improved robustness.
Batch conditioning robustness:
prepare_batch_conditionsmethod ofmodel.py, ensuring consistent handling of conditioning data even when input images have different aspect ratios.Training example handling:
_pop_training_example_for_pathfunction incollate.pyto pass an explicitis_conditioningflag when the conditioning type is"reference_loose", improving clarity and correctness in downstream processing.Test improvements:
check_latent_shapesintest_collate.pyto accept arbitrary keyword arguments, preventing potential errors during testing.