A bug fixed in click event of pies #177
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hi @HRezaei, thanks for the PR! I actually haven't been supporting this library for some time and rather hoped someone would be willing to take the project over. I posted a comment at the top of the README hoping for that, but no dice! As mentioned, I'm heading out of town for 2 weeks and won't be doing much dev work, but let me revisit this lib when I get back and see if I can get a few things updated without spending too much time on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an error spotted in the event of click on segments.
In almost all (not checked all) samples, pie is defined as a global variable and is used as ID of an element in the page, thus made the error invisible.
To reproduce the error you can change simple.html and rename pie variable (line 24) and ID of div element (line 18) to something else, then open the page and click on segments.
Fixes issues: #174 , #144 , #133