Fillup method in import-notation #312
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
Vittly
force-pushed
the
fillup@import-notation
branch
from
70fd18d to
0e8ff34
Compare
yarastqt
reviewed
May 6, 2018
| scope && (importString = helpers.fillup(importString, scope)); | ||
|
|
||
| return Array.from(importString.split(' ').reduce((acc, importToken) => { | ||
| const split = importToken.split(':'), |
Member
There was a problem hiding this comment.
Кажется, что split больше нигде не используется, можно на деструкторизацию заменить:
const [type, value] = importToken.split(':');
yarastqt
reviewed
May 6, 2018
| main.elem = val; | ||
| break; | ||
| case 'm': { | ||
| const splitMod = val.split('='), |
Member
There was a problem hiding this comment.
Аналогично — можно заменить на деструкторизацию
Collaborator
Author
There was a problem hiding this comment.
Member
There was a problem hiding this comment.
Кажется, что стоит отказаться от 4 версии, она вот-вот прекратит поддерживаться
Collaborator
Author
There was a problem hiding this comment.
создай плиз issue про это со ссылкой на место, где написано, что она перестанет поддерживаться
yarastqt
reviewed
May 6, 2018
| && !~acc.m[cell.mod.name].indexOf(cell.mod.val) | ||
| && acc.m[cell.mod.name].push(cell.mod.val); | ||
| cell.tech && (acc.t = cell.tech); | ||
| && !~acc.mod[cell.mod.name].indexOf(cell.mod.val) |
Member
There was a problem hiding this comment.
Ну камон ребята: !~acc.mod[cell.mod.name].indexOf(cell.mod.val), запишите нормально
Collaborator
Author
There was a problem hiding this comment.
тут везде такое кунфу) но мне тож не нравится
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.