Skip to content

[9.1.0] Update MODULE.bazel and .bazelversion for 9.1.0 #28375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Wyverald merged 7 commits into from
Jan 21, 2026
Merged

[9.1.0] Update MODULE.bazel and .bazelversion for 9.1.0 #28375

Wyverald merged 7 commits into from
Jan 21, 2026

Conversation

@Wyverald
Copy link
Member

@Wyverald Wyverald commented Jan 21, 2026 •
edited
Loading

Along with cherry-picks to fix the build:

Wyverald and others added 4 commits January 21, 2026 17:01
@Wyverald
update version
e9daeb0
@meteorcloudy @Wyverald
Set a minimal compatible version of onetbb for bazel 9
b7fe4d0 
Fixes downstream: https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/5132#019b0675-1eeb-4643-981b-aa60e6c69774

PiperOrigin-RevId: 842627250
Change-Id: Iec3660d2849bebe0d8a314392a01126421d0e873
@meteorcloudy @Wyverald
Patch rules_graalvm for Bazel 9
eedec47 
Closes #28014.

PiperOrigin-RevId: 845680411
Change-Id: I4454ed2731b24ec051ee633460e8bb120fb07d04
@hvadehra @Wyverald
Update rules_java to v9.1.0
c992871 
PiperOrigin-RevId: 838699215
Change-Id: I7f9720f759e2ca02ff09566648972f38798307a0
@Wyverald Wyverald requested a review from a team as a code owner January 21, 2026 22:17
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Jan 21, 2026
@meteorcloudy @Wyverald
Internal change
dce1873 
- Some copybara improvements
- Fixes #28271

PiperOrigin-RevId: 855674250
Change-Id: I238ff6a4888e7b78b45fdbe0a9c72671fcfd18ca
@Wyverald Wyverald mentioned this pull request Jan 21, 2026
Closed
gemini-code-assist[bot]
gemini-code-assist bot reviewed Jan 21, 2026
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the module version to 9.1.0 and adjusts dependencies accordingly, including updating rules_java and adding onetbb. The changes are mostly consistent with a version bump. However, there is a critical inconsistency in the .bazelversion file, which has been updated to 9.0.0 instead of 9.1.0 as suggested by the pull request title. This should be corrected to ensure the correct Bazel version is used for builds.

.bazelversion
@@ -1 +1 @@
8.4.2 No newline at end of file
9.0.0 No newline at end of file
Copy link

@gemini-code-assist gemini-code-assist bot Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

There is a version mismatch. The pull request title, [9.1.0] Update MODULE.bazel and .bazelversion for 9.1.0, indicates that the Bazel version should be 9.1.0. However, the version in this file is set to 9.0.0. This discrepancy could lead to using an incorrect Bazel version, potentially causing build issues. Please align the version with the one specified in the PR title.

9.1.0

Copy link
Member Author

@Wyverald Wyverald Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is intentional. We use Bazel 9.0.0 to build the code on the release-9.1.0 branch. Bazel 9.1.0 is not released yet.

@meteorcloudy @Wyverald
Set --test_env=PATH on Windows
05cecdc 
We need to set this flag with the flip of --incompatible_strict_action_env in Bazel 9

Fixes https://buildkite.com/bazel/bazel-bazel-github-presubmit/builds/31307#019bbc0d-7e31-4ce0-8289-73d9da2e4eb0

PiperOrigin-RevId: 856202564
Change-Id: If3273976dc2ffd20e73e5767260ddce88d27bd7d
@meteorcloudy @Wyverald
Fix tests with Bazel 9
6fe8a0c 
- Pass --test_env=PATH to tests
- Make sure MSYS bin dir is respected for tools like `find`.

Related #28294

Fixes #28297
Fixes #28233

PiperOrigin-RevId: 857016089
Change-Id: I7b5d206ff63554631d3c64a42f9225a51c55752f
@Wyverald Wyverald enabled auto-merge January 21, 2026 23:07
@iancha1992 iancha1992 added this to the 9.1.0 release blockers milestone Jan 21, 2026
@Wyverald Wyverald added this pull request to the merge queue Jan 21, 2026
Merged via the queue into release-9.1.0 with commit 13dd3c4 Jan 21, 2026
48 checks passed
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iancha1992 iancha1992 iancha1992 approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

9.1.0 release blockers

Development

Successfully merging this pull request may close these issues.

5 participants

@Wyverald @iancha1992 @meteorcloudy @hvadehra