feat: fetch jars for gem dependencies #327
Open
+272
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p0deje
force-pushed
the
feat/jars
branch
3 times, most recently
from
b026767 to
622b92f
Compare
Collaborator
|
@p0deje do you think this could mean https://github.com/bazel-contrib/rules_ruby/blob/main/examples/proto/.ruby-version could switch to jruby also? |
Member
Author
|
@alexeagle Not sure, what was the problem with using JRuby on protobuf example? |
Collaborator
|
#335 should repro it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR automatically fetches gem JARs during
rb_bundle_fetch, then exposes them at runtime via theJARS_HOMEenvironment variable. This mostly mimics what JRuby is doing duringbundle install, but we cannot do so sincerb_bundle_installis an action and might not have network access. Instead, all the downloading should happen insiderb_bundle_fetch.Fixes #218.
@noahkawasakigoogle Any chance you might be able to test this on your repo?