feat(zipapp): add content hash support to __main__-based invocations#3683
Merged
rickeylev merged 9 commits intobazel-contrib:mainfrom Apr 5, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a content-based hashing mechanism for zipapp extraction directories to ensure uniqueness. It replaces the standard template expansion with a custom zip_main_maker tool that computes a SHA256 hash of the application's runfiles and injects it into the __main__.py template. Feedback highlights a bug in the template substitution logic where overlapping placeholder names could cause incorrect replacements, and suggests refactoring duplicated manifest-building logic in the Starlark rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for zipapps going through
__main__to extract to a directorybased on their content hash. This matches behavior of the shell-based
self-executable bootstrap.