Add pre-commit hook for running addlicense

[rickeylev]

Integrate the addlicense.sh script with the pre-commit config so that it automatically runs when git committing.

[alexeagle]

The standard way to do this is expose a pre-commit hook from the addlicense repo, so that everyone can add it, and you don't need a shell script or a new .pre-commit-hooks.yaml here

[rickeylev]

Thanks for the pointer. I sent google/addlicense#143. Once accepted (I don't see why it wouldn't be...), we'll have to wait for them to do a release with a stable tag to use in the configs. I have another PR ready for when that happens.

In the meantime, I found the docs that tell how to correctly setup a local hook and updated the code to do that. PTAL.

[f0rmiga]

It bothers me that pre-commit doesn't use Bazel for the binaries. The best way to deal with this is:

• Pull the binaries using http_archives.
• Create an alias with selects to resolve the platform.
• Create a shell wrapper that cd into BUILD_WORKSPACE_DIRECTORY and execute the binary:

#!/usr/bin/env bash

set -o errexit -o nounset

cd "${BUILD_WORKSPACE_DIRECTORY}"

exec "${ADDLICENSE_BINARY}" "$@"

• Add the entry attribute to the pre-commit hook with entry: "bazel run //<pre-commit wrappers package>:addlicense --".

[alexeagle]

Pre-commit running Bazel is not great due to pre-commit/pre-commit#1003 (comment)
I think it does a pretty good job of providing the hermetic tooling and there's no need for Bazel where there's no dependency graph IMO

[chrislovecnm]

Can we get this into a test? CI should fail on this.

[chrislovecnm]

@rickeylev ping

[github-actions]

This Pull Request has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days.
Collaborators can add an assignee to keep this open indefinitely. Thanks for your contributions to rules_python!

[github-actions]

This PR was automatically closed because it went 30 days without a reply since it was labeled "Can Close?"