test: Construct a test for running in the cwd.
#112
Conversation
This doesn't work for me -- this test is a reproduction of the `:cwd` target for a multitool not finding the `tool`.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| name = "run_gh_alias_import", | ||
| srcs = ["test_gh_aliases.yaml"], | ||
| outs = ["run_gh_alias_import.out"], | ||
| cmd = "$(location @multitool//tools/gh:cwd) alias import test_gh_aliases.yaml && touch run_gh_alias_import.out", |
There was a problem hiding this comment.
Building //examples/module:run_gh_alias_import runs gh alias import test_gh_aliases.yaml without a $(location ...) expansion, but genrule commands execute from the output directory and do not stage source files there. In sandboxed or remote builds the YAML won’t be found, so the new build_test will fail every time. Use $(location test_gh_aliases.yaml) (or $(SRCS)) so the command can see its input file.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Thi s is intentional because I want the :cwd to find the file in the working directory, simulating a tool that expects a config file in the cwd.
There was a problem hiding this comment.
I’m not sure I understand the issue you’re trying to test — :cwd doesn’t work for you, or config files in the current working directory are not available to you when running using bazel run?
There was a problem hiding this comment.
:cwd doesn't work -- the wrapper script gets a file not found error trying to execute the tool when in a genrule or run_binary context.
I expected to be able to use :cwd to say "run the command in the current path, because this program has weird behaviour that expects its config file to exist in the location it's run in."
2 participants
Running
:cwdin agenruledoesn't find the tool -- it reports afile not founderror.