Ignore hotkeys with modifiers #2281
Conversation
Avoids unintentionally triggering when using system shortcuts like `command+[` in macOS
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| handleKeydown(event) { | ||
| if (this.#shouldIgnore(event)) return | ||
| if (this.#shouldIgnore(event) || this.#hasModifier(event)) return | ||
|
|
There was a problem hiding this comment.
Ignoring all keydown events with any modifier (meta/ctrl/alt/shift) means users on keyboard layouts that require AltGr/Option or another modifier to type [ or ] can no longer trigger the postpone/close card shortcuts at all. The intent was to avoid system shortcuts like Command+[ on macOS, but this guard also blocks legitimate hotkey usage for non‑US layouts that need modifiers to emit those characters.
Useful? React with 👍 / 👎.
Avoids unintentionally triggering when using system shortcuts like
command+[in macOS. See: https://app.fizzy.do/5986089/cards/3594