Skip to content

Comments

scaffolder-backend-module-azure-devops: Fix pipeline result output#7645

Open
SanderDelden wants to merge 1 commit intobackstage:mainfrom
SanderDelden:7639-fix-pipeline-run-result-output
Open

scaffolder-backend-module-azure-devops: Fix pipeline result output#7645
SanderDelden wants to merge 1 commit intobackstage:mainfrom
SanderDelden:7639-fix-pipeline-run-result-output

Conversation

@SanderDelden
Copy link

Hey, I just made a Pull Request!

Closes #7639

This is my first PR for Backstage and also the first time working with TypeScript, so apologies in advance if things are not perfect!

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@backstage-goalie
Copy link
Contributor

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage-community/plugin-scaffolder-backend-module-azure-devops workspaces/azure-devops/plugins/scaffolder-backend-module-azure-devops patch v0.20.1

@SanderDelden
Copy link
Author

I see that the tests are failing, unfortunately I was not able to run them locally prior to pushing as I got the following error:
image

Any help with this would be greatly appreciated so I can test and verify locally and fix the checks :)

@SanderDelden SanderDelden force-pushed the 7639-fix-pipeline-run-result-output branch from aa0b43d to e1a79d5 Compare February 19, 2026 12:38
Signed-off-by: Sander van Delden <38953576+SanderDelden@users.noreply.github.com>
@SanderDelden SanderDelden force-pushed the 7639-fix-pipeline-run-result-output branch from e1a79d5 to ce09f23 Compare February 19, 2026 12:58
@SanderDelden
Copy link
Author

Tests are fixed :)

@awanlin
Copy link
Contributor

awanlin commented Feb 19, 2026

HI @Phiph, can you give this a look please?

@awanlin
Copy link
Contributor

awanlin commented Feb 19, 2026

Hi @SanderDelden, I'll review this tomorrow afternoon 👍

Copy link
Contributor

@awanlin awanlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @SanderDelden, thanks for the contribution, technically this looks good to me, just left a comment about the changeset.

I'd like a review from @Phiph who is the author of this action to get his impression and thoughts as well.

'@backstage-community/plugin-scaffolder-backend-module-azure-devops': patch
---

Fixed bug in createAzureDevopsRunPipelineAction where pipelineRun.result returned an integer instead of the corresponding string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Fixed bug in createAzureDevopsRunPipelineAction where pipelineRun.result returned an integer instead of the corresponding string
**BREAKING** Fixed bug in `createAzureDevopsRunPipelineAction` where `pipelineRun.result` returned an integer instead of the corresponding string

This should likely be minor and not patch, it's also a breaking change given that people who use this may be expecting the integer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 scaffolder-backend-module-azure-devops: Pipeline run result is reported as integer instead of string

3 participants