Skip to content

Conversation

@necipsagiro
Copy link
Contributor

@necipsagiro necipsagiro commented Dec 23, 2025

resolves #313

  • all test types now generate separate coverage files in coverage/{unit,integration,e2e}/ directories using binary format
  • added test-all and coverage-all targets for combined coverage
  • added coverage-report target to generate and print total coverage percentage
  • enabled integration tests and combined with e2e tests in single command
  • fixed timestamp parsing to use UTC

CI now runs all three test types sequentially and generates combined coverage report with total percentage

@necipsagiro necipsagiro linked an issue Dec 23, 2025 that may be closed by this pull request
@necipsagiro necipsagiro marked this pull request as ready for review December 23, 2025 21:03
Copilot AI review requested due to automatic review settings December 23, 2025 21:03
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds end-to-end (e2e) tests to the CI pipeline and improves test coverage management. The main change enables running all three test types (unit, integration, e2e) separately in CI with individual coverage files, while also providing a way to combine them for total coverage reporting. Additionally, it fixes timestamp parsing to consistently use UTC timezone.

  • Separate coverage files for unit, integration, and e2e tests
  • New test-all and coverage-all Make targets for combined test execution and coverage viewing
  • Integration and e2e tests now run together in CI pipeline
  • Timestamp formatting fixed to use UTC (Z suffix) instead of local timezone offsets

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
.github/workflows/ci.yml Enables integration tests in CI and configures command to run both integration and e2e tests
Makefile Updates test targets to generate separate coverage files and adds targets for combined test execution and coverage reporting
internal/shared/utils/timestamp.go Fixes timestamp parsing to explicitly use UTC timezone
tests/api/v1_test.go Updates expected test outputs to reflect UTC timestamp format change (from +04:00 offset to Z suffix)
tests/api/v2_test.go Adds max_staking_apr field to expected stats response
tests/api/testdata/indexer/stats.json Adds test fixture data for stats endpoint testing

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jrwbabylonlab jrwbabylonlab force-pushed the 313-add-e2e-tests-to-ci-pipeline branch from 7ba230b to e74a6ac Compare January 21, 2026 04:29
@jrwbabylonlab jrwbabylonlab merged commit 1166dbc into main Jan 21, 2026
18 checks passed
@jrwbabylonlab jrwbabylonlab deleted the 313-add-e2e-tests-to-ci-pipeline branch January 21, 2026 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add e2e tests to CI pipeline

3 participants