-
Notifications
You must be signed in to change notification settings - Fork 12
test: add e2e tests to ci pipeline #481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds end-to-end (e2e) tests to the CI pipeline and improves test coverage management. The main change enables running all three test types (unit, integration, e2e) separately in CI with individual coverage files, while also providing a way to combine them for total coverage reporting. Additionally, it fixes timestamp parsing to consistently use UTC timezone.
- Separate coverage files for unit, integration, and e2e tests
- New
test-allandcoverage-allMake targets for combined test execution and coverage viewing - Integration and e2e tests now run together in CI pipeline
- Timestamp formatting fixed to use UTC (Z suffix) instead of local timezone offsets
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/ci.yml |
Enables integration tests in CI and configures command to run both integration and e2e tests |
Makefile |
Updates test targets to generate separate coverage files and adds targets for combined test execution and coverage reporting |
internal/shared/utils/timestamp.go |
Fixes timestamp parsing to explicitly use UTC timezone |
tests/api/v1_test.go |
Updates expected test outputs to reflect UTC timestamp format change (from +04:00 offset to Z suffix) |
tests/api/v2_test.go |
Adds max_staking_apr field to expected stats response |
tests/api/testdata/indexer/stats.json |
Adds test fixture data for stats endpoint testing |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
7ba230b to
e74a6ac
Compare
resolves #313
coverage/{unit,integration,e2e}/directories using binary formattest-allandcoverage-alltargets for combined coveragecoverage-reporttarget to generate and print total coverage percentageCI now runs all three test types sequentially and generates combined coverage report with total percentage