Guardian's Glade initial template #1112
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@EliphasNUIT can merge |
EliphasNUIT
reviewed
Feb 3, 2026
|
|
||
| internal override void EIEvtcParse(ulong gw2Build, EvtcVersionEvent evtcVersion, LogData logData, AgentData agentData, List<CombatItem> combatData, IReadOnlyDictionary<uint, ExtensionHandler> extensions) | ||
| { | ||
|
|
Collaborator
There was a problem hiding this comment.
EIEvtcParse must always base method.
GetPhases and CheckSuccess should call their base methods until they are properly implemented.
EliphasNUIT
reviewed
Feb 3, 2026
| LogID |= LogIDs.RaidEncounterMasks.VoEMask; | ||
| } | ||
|
|
||
| internal override void CheckSuccess(CombatData combatData, AgentData agentData, LogData logData, IReadOnlyCollection<AgentItem> playerAgents, LogData.LogSuccessHandler successHandler) |
Collaborator
There was a problem hiding this comment.
After verification, if possible, make this class inherit from PostEodRaidEncounterLogic and you can remove this specific CheckSuccess override
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.