[TASK] Ensure working codeception tests with TYPO3 v13 #566
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[TASK] Adjust
typo3/testing-frameworkconstraintThe composer package version constraint for the
typo3/testing-frameworkis adjusted to ensurelatest version for each required major versions.
Used command(s):
[1] https://github.com/TYPO3/testing-framework/releases/tag/8.2.7
[TASK] Remove providing backend entrypoint for TYPO3 v13 in test instance
TYPO3 v13.0 dropped the backend entrypoint (
./typo3/index.php)and made the main entrypoint (
./index.php) capable of handlingfrontend and backend web requests to make the backend entrypoint
finally configurable and required to change the rewrite rules for
webservers to ensure backend requests hits the main entrypoint.
The acceptance setup for
b13/containeris based on the TYPO3monorepo setup using a real
Apache2webserver instead of thePHP internal webserver and thus needs
.htaccessrules to work.Providing needed
.htaccessfiles has been added to the TYPO3monorepo only and broke the setup for acceptance testing against
TYPO3 v13. As a workaround providing the old backend entrypoint
file has been implemented within the extended codeception setup
method
BackendContainerEnvironment::bootstrapTypo3Environment()which worked but is literally wrong.
typo3/testing-frameworknow provides these files automatically,and the wrong workaround can be removed to cleanup the code base
[1][2][3][4] and is backwards compatible for older TYPO3 versions.
Some phpstan ignore pattern can be now removed from baselines and
is done in the same run.
[1] [TASK] Allow defining test instance files copy for acceptance tests TYPO3/testing-framework#663
[2] [TASK] Allow defining test instance files copy for acceptance tests TYPO3/testing-framework#664
[3] https://github.com/TYPO3/testing-framework/releases/tag/9.1.2
[4] https://github.com/TYPO3/testing-framework/releases/tag/8.2.7
[TASK] Use composer package names for acceptance extension configuration
typo3/testing-frameworkallows to use composer package namesinstead of classic mode references as extension to load for
functional and codeception acceptance test instance creation.
Use composer package names for acceptance test extensions to
load now.
[TASK] Adopt codeception helper login page check from testing-framework
For the codeception acceptance tests a custom codeception helper
is used to verify the login state, using
/typo3/index.phptocheck for backend login mask page.
Using the full endpoint is not reasonable and breaks with TYPO3
v13.0 and newer which removed that endpoint completly and this
change modifes the check to use
/typo3path instead, adoptingfrom provided
typo3/testing-frameworkhelper which is fullybackwards compatible.
[TASK] Use
apache2andPHP-FPMfor acceptance tests for TYPO3 v13TYPO3 Core development switched codeception based acceptance
testing using
apache2andPHP-FPMinstead if the internalPHP cli webserver due to rewrite rules required to operate
TYPO3 properly, special with removed backend entrypoint since
TYPO3 v13.
This change adopts required changes within
Build/Scripts/runTests.shto make the switch and be in line with core development regarding
acceptance testing for TYPO3 v13 only, keeping the PHP internal
webserver for older TYPO3 core and testing-framework versions.