refactor(core): move get_payload and _build_import_definition to fab_cmd_import_utils#77
Draft
refactor(core): move get_payload and _build_import_definition to fab_cmd_import_utils#77
Conversation
Copilot created this pull request from a session on behalf of
ayeshurun
March 15, 2026 09:21
View session
ayeshurun
reviewed
Mar 16, 2026
tests/test_core/test_fab_hiearchy.py
Outdated
| } | ||
| } | ||
|
|
||
| def _get_payload(item, definition, input_format=None): |
Owner
There was a problem hiding this comment.
@copilot instead of defining this method, use and import get_payload_for_item_type method and use it in unit tests.
Author
There was a problem hiding this comment.
Replaced the local _get_payload helper with the actual get_payload_for_item_type imported from fab_cmd_import_utils, using unittest.mock.patch to mock _build_payload for the filesystem-dependent part. Also updated the payload tests in TestBuildImportDefinition to use the same pattern. All 451 tests pass. See 1413ea2.
Copilot
AI
changed the title
refactor(core): replace match/case in get_payload with data-driven set and helper method
refactor(core): move get_payload and _build_import_definition to fab_cmd_import_utils
Mar 16, 2026
…cmd_import_utils - Create shared resolve_definition_format utility in fab_item_util.py - Update fab_fs_export_item.py and fab_fs_import_item.py to use shared function - Add invalid_definition_format to ExportErrors with backward-compatible alias - Consolidate common format validation pattern across export/import commands Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
ayeshurun
force-pushed
the
copilot/refactor-get-payload-function
branch
from
b920643 to
87fe82d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor: move
get_payloadand format-building logic fromItemclass tofab_cmd_import_utilsget_payloadfromfab_item.pytoget_payload_for_item_typeinfab_cmd_import_utils.pywith a simplified generic implementation_build_import_definitioninto_build_definitioninfab_cmd_import_utils.py, usingdefinition_format_mappingto resolve format valuesresolve_definition_formatutil infab_item_util.pyused by both export and importErrorMessages.Export.invalid_definition_format🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.