[Draft, don't merge] Add host label validation for region before ep resolution #612
+46
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wty-Bryant
changed the title
Madrigal
reviewed
Nov 6, 2025
Contributor
Madrigal
left a comment
Madrigal
left a comment
There was a problem hiding this comment.
Change LGTM, even though it's not akshually checking for all cases mentioned in the RFC, specifically
They must start with a letter, end with a letter or digit
ref, but this is good enough
There's some internal discussion about this, so let's get consensus on it before merging
| } | ||
| """, | ||
| MapUtils.of( | ||
| "validHost", SmithyGoTypes.Transport.Http.ValidHostLabel, |
Contributor
There was a problem hiding this comment.
For context, this is the host label function
smithy-go/transport/http/host.go
Line 73 in 299f404
it's basically checking x < 64 && x.match([azAZ09-])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.