Skip to content

Throw invalid model for lowercase shape names#6570

Merged
dagnir merged 1 commit intomasterfrom
dongie/validation-error-lowercase-shape
Nov 15, 2025
Merged

Throw invalid model for lowercase shape names#6570
dagnir merged 1 commit intomasterfrom
dongie/validation-error-lowercase-shape

Conversation

@dagnir
Copy link
Contributor

@dagnir dagnir commented Nov 15, 2025

Motivation and Context

Modifications

Testing

Updated existing test.

Tested locally by updating a service model (acm) and verifying that the correct exception is thrown during generation time and checked the contents of the generated report.

mvn clean install -pl :acm -DwriteValidationReport=true

cat services/acm/target/generated-sources/sdk/models/validation-report.json

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@dagnir dagnir requested a review from a team as a code owner November 15, 2025 00:22
@dagnir dagnir added the changelog-not-required Indicate changelog entry is not required for a specific PR label Nov 15, 2025
@dagnir dagnir enabled auto-merge November 15, 2025 00:31
@dagnir dagnir disabled auto-merge November 15, 2025 00:33
@dagnir dagnir force-pushed the dongie/validation-error-lowercase-shape branch from 8b6b9c4 to 06c97af Compare November 15, 2025 00:34
@dagnir dagnir enabled auto-merge November 15, 2025 00:34
@sonarqubecloud
Copy link

@dagnir dagnir added this pull request to the merge queue Nov 15, 2025
Merged via the queue into master with commit e7032e8 Nov 15, 2025
37 of 39 checks passed
@github-actions
Copy link

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2025
@dagnir dagnir deleted the dongie/validation-error-lowercase-shape branch November 17, 2025 17:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

changelog-not-required Indicate changelog entry is not required for a specific PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants