Increase default chunk size for async request#6542
Merged
Conversation
Contributor
should we just increase to 128 KB to be consistent with sync? |
zoewangg
reviewed
Nov 4, 2025
| * Default chunk size for Async trailer based checksum data transfer* | ||
| */ | ||
| public static final int DEFAULT_ASYNC_CHUNK_SIZE = 16 * 1024; | ||
| public static final int DEFAULT_ASYNC_CHUNK_SIZE = 64 * 1024; |
Contributor
There was a problem hiding this comment.
This is only used by legacy code, right?
Contributor
Author
There was a problem hiding this comment.
Yes, the SRA path is already consistent with sync by this change: #6514 . Changed the wording in changelog.
Fred1155
added
the
no-api-surface-area-change
…-sdk-java-v2 into bole/increase_default_chunk_size
11 tasks
zoewangg
approved these changes
Nov 5, 2025
S-Saranya1
approved these changes
Nov 6, 2025
|
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
According to public S3 documentation, https://docs.aws.amazon.com/AmazonS3/latest/API/sigv4-streaming.html , the chunk size is recomended to be at least 64 Kb to achieve better performance. The current default chunk size for sync is 128 KB. With the change in #6514 , the default chunk size for async request using SRA is also 128 KB. However the default chunk size for async for legacy code path is 16 Kb.
Modifications
Increase the DEFAULT_ASYNC_CHUNK_SIZE from 16Kb to 128Kb
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License