Skip to content

Conversation

@KENNYSOFT
Copy link
Contributor

@KENNYSOFT KENNYSOFT commented May 27, 2025

Motivation and Context

I found a typo and would like to correct it. Fixes #6141

Modifications

Correct return type of AsyncRequestBody.forBlockingOutputStream

Testing

N/A

Screenshots (if appropriate)

N/A

However, I encountered a local test failure due to the throwable message i18n, which seems to be from the OS:

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@dagnir dagnir enabled auto-merge January 14, 2026 23:10
@dagnir dagnir added the no-api-surface-area-change Indicate there is no API surface area change and thus API surface area review is not required label Jan 14, 2026
@sonarqubecloud
Copy link

@dagnir dagnir added this pull request to the merge queue Jan 14, 2026
Merged via the queue into aws:master with commit 0ff68a1 Jan 15, 2026
22 of 47 checks passed
@dagnir
Copy link
Contributor

dagnir commented Jan 15, 2026

@all-contributors please add @KENNYSOFT for doc

@allcontributors
Copy link
Contributor

@dagnir

I've put up a pull request to add @KENNYSOFT! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-api-surface-area-change Indicate there is no API surface area change and thus API surface area review is not required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Example for AsyncRequestBody.forBlockingOutputStream looks wrong.

2 participants