Skip to content

fix: remove timeout from Invoke Config#340

Open
AdityaAudi wants to merge 1 commit intoaws:mainfrom
AdityaAudi:fix/remove-invoke-config-timeout
Open

fix: remove timeout from Invoke Config#340
AdityaAudi wants to merge 1 commit intoaws:mainfrom
AdityaAudi:fix/remove-invoke-config-timeout

Conversation

@AdityaAudi
Copy link
Copy Markdown
Contributor

Breaking change: Customers passing timeout= to InvokeConfig will receive a TypeError on upgrade. Targeting v2!

Summary

Removes the unused timeout field from InvokeConfig as described in #321

The field was passed to suspend_with_optional_resume_delay as a polling retry delay, but this has no meaningful effect, invoke completion is pushed by the backend, not polled. The field was misleadingly named and did not enforce any actual timeout on the invocation.

Changes

  • config.py - removed timeout: Duration field and timeout_seconds property from InvokeConfig
  • operation/invoke.py - suspend_with_optional_resume_delay called without delay (indefinite suspend)
  • tests/ - removed Duration import, removed/updated all timeout-specific invoke tests
  • docs/architecture.md - removed timeout_seconds from InvokeConfig class diagram
  • docs/core/invoke.md - removed all timeout references (terminology, config, error handling, best practices, FAQ, testing)

Test plan

  • All existing tests pass (hatch test -- -p no:randomly)
  • Removed timeout-specific tests that no longer apply
  • Updated tests that used timeout= incidentally now use default InvokeConfig()

@yaythomas yaythomas moved this from Backlog to Ready in aws-durable-execution Apr 7, 2026
@yaythomas yaythomas added this to the v2 milestone Apr 7, 2026
@yaythomas
Copy link
Copy Markdown
Contributor

thank you very much @AdityaAudi!

I've flagged this for v2 with milestone.

@AdityaAudi AdityaAudi changed the title fix: remove timeout from Invoke Config (v2 breaking change!) fix: remove timeout from Invoke Config Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Ready

Development

Successfully merging this pull request may close these issues.

2 participants