Merged
Conversation
yaythomas
previously requested changes
Apr 6, 2026
yaythomas
reviewed
Apr 6, 2026
yaythomas
reviewed
Apr 6, 2026
yaythomas
reviewed
Apr 6, 2026
yaythomas
reviewed
Apr 6, 2026
7d829d0 to
5bbf198
Compare
Empty checkpoints (used by map/parallel branch resubmitters when resuming from timed waits) no longer count toward the 250-operation batch limit beyond the first. This prevents 300+ concurrent branch resumes from splitting across multiple API batches. closes aws#325 Co-authored-by: Aditya Ganti <aditya.ganti95@gmail.com>
5bbf198 to
677980f
Compare
yaythomas
approved these changes
Apr 6, 2026
Contributor
|
thank you so much for picking this up @AdityaAudi, much appreciated! 🙇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the empty-checkpoint coalescing optimization described in #325.
When many concurrent
map/parallelbranches resume from awaitoperation simultaneously, each branch's resubmitter enqueues an empty checkpoint (noOperationUpdate). Previously, these counted toward the 250-operation batch limit, causing 300 concurrent branches to produce 2 API calls (250 + 50) instead of 1.effective_operation_countseparately fromlen(batch)