feat - custom endpoint plugin #275
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronchung-bitquill
force-pushed
the
feat/custom-endpoint-plugin
branch
3 times, most recently
from
b52d465 to
b560b5f
Compare
aaronchung-bitquill
force-pushed
the
feat/custom-endpoint-plugin
branch
from
b560b5f to
f5ad9ce
Compare
| ctrl := gomock.NewController(t) | ||
| defer ctrl.Finish() | ||
|
|
||
| mockPluginService := mock_driver_infrastructure.NewMockPluginService(ctrl) |
Contributor
Author
There was a problem hiding this comment.
Lot of repeated mocking code across the tests. Should see if its possible to put this into a single function.
| } | ||
|
|
||
| func (p *PluginServiceImpl) GetHosts() []*host_info_util.HostInfo { | ||
| // TODO: transfer some uses of #GetHost to #GetAllHosts |
Contributor
Author
There was a problem hiding this comment.
Remove this
sophia-bq
reviewed
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Description
Additional Reviewers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.