Skip to content

Enhance password rotation logic in set_secret function for Oracle by replacing the current password during update #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Enhance password rotation logic in set_secret function for Oracle by replacing the current password during update #166

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion SecretsManagerRDSOracleRotationSingleUser/lambda_function.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,9 +169,11 @@ def set_secret(service_client, arn, token):

# Now try the current password
conn = get_connection(current_dict)
current_pass = current_dict["password"]
if not conn and previous_dict:
# If both current and pending do not work, try previous
conn = get_connection(previous_dict)
current_pass = previous_dict["password"]

# Make sure the user/host from previous and pending match
if previous_dict['username'] != pending_dict['username']:
Expand All @@ -196,7 +198,7 @@ def set_secret(service_client, arn, token):
pending_password = pending_dict['password'].replace("\"", "")

# Now set the password to the pending password
sql = "ALTER USER %s IDENTIFIED BY \"%s\"" % (escaped_username, pending_dict['password'])
sql = "ALTER USER %s IDENTIFIED BY \"%s\" REPLACE \"%s\"" % (escaped_username, pending_dict['password'], current_pass)
cur.execute(sql)
conn.commit()
logger.info("setSecret: Successfully set password for user %s in Oracle DB for secret arn %s." % (pending_dict['username'], arn))
Expand Down