chore(parameters): Thread safety #1098
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add BatchProcessingStressTests for high-concurrency and sustained load validation - Add BatchProcessingThreadSafetyTests to verify thread-safe record processing - Add isolation tests for DynamoDB, Kinesis, SQS, and typed batch processors - Add StaticResultPropertyTests to validate static result property behavior - Add helper classes for concurrent invocation results, test event factory, and record handlers - Add project reference to BatchProcessing library in test project - Verify batch processor maintains correctness under high concurrency (20-100 concurrent invocations) - Validate thread safety with concurrent record processing and state isolation - Ensure no record leakage between concurrent invocations - Test stress scenarios with varying concurrency levels and iteration counts
…ic operations - Replace mutable CacheObject properties with immutable read-only fields to prevent concurrent modification issues - Change CacheManager.Set() to use atomic AddOrUpdate instead of TryGetValue/TryAdd pattern for thread-safe cache updates - Convert CacheObject to sealed class and make Value and ExpiryTime properties read-only - Replace nullable TimeSpan _defaultMaxAge with long _defaultMaxAgeTicks for Interlocked compatibility - Convert _raiseTransformationError from bool to volatile int for Interlocked operations - Mark _cache and _transformManager fields as volatile to ensure visibility across threads - Use Interlocked.Exchange and Interlocked.Read for atomic access to _defaultMaxAgeTicks - Add comprehensive concurrency tests for cache thread safety, parameter retrieval, async context, and transformer operations - Update InternalsVisibleTo to expose new test helpers for concurrency testing - Ensures Parameters module is safe for concurrent access in multi-threaded Lambda environments
pull-request-size
bot
added
the
size/XXL
hjgraca
changed the title
hjgraca
changed the title
hjgraca
changed the title
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #1098 +/- ##
===========================================
+ Coverage 78.50% 78.95% +0.44%
===========================================
Files 299 299
Lines 12375 12435 +60
Branches 1492 1489 -3
===========================================
+ Hits 9715 9818 +103
+ Misses 2186 2140 -46
- Partials 474 477 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
leandrodamascena
previously approved these changes
Dec 18, 2025
2 tasks
…atting - Add System.Globalization using statement to KafkaHandlerFunctionalTests.cs - Add System.Globalization using statement to Protobuf/HandlerTests.cs - Replace string interpolation with string.Format using CultureInfo.InvariantCulture in JSON handler test - Replace string interpolation with string.Format using CultureInfo.InvariantCulture in Avro handler test - Replace string interpolation with string.Format using CultureInfo.InvariantCulture in Protobuf handler test - Replace string interpolation with string.Format using CultureInfo.InvariantCulture in ProtobufHandlerTests - Ensure consistent culture-independent string formatting across all Kafka test handlers
- Convert test methods from synchronous to async Task return types - Replace CountdownEvent with TaskCompletionSource for async-friendly synchronization - Replace Thread.Sleep with await Task.Delay for non-blocking delays - Replace Task.Run with async lambda expressions for proper async context - Replace ManualResetEventSlim with TaskCompletionSource for event signaling - Use Task.WhenAll instead of Task.WaitAll for async task completion - Use Interlocked.Increment for thread-safe counter management - Improve assertion messages for better test failure diagnostics - Eliminate blocking synchronization primitives in favor of async patterns for better concurrency testing
|
leandrodamascena
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #1097
Summary
Changes
User experience
Checklist
Please leave checklist items unchecked if they do not apply to your change.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.