-
Notifications
You must be signed in to change notification settings - Fork 34
Enable black formatter #152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The "setup.py test" is deprecated. We could either run the tests directly by "-m unittest" or simply rely on well established runner "pytest". Let's use the second way here. Signed-off-by: Lukáš Doktor <[email protected]>
"setup.py develop" is deprecated, use pip instead. Signed-off-by: Lukáš Doktor <[email protected]>
the double-curly-brackets do not require escaping and fails in black linter. Signed-off-by: Lukáš Doktor <[email protected]>
address all python black style issues. Signed-off-by: Lukáš Doktor <[email protected]>
to keep the formatting correct add python black to the "make check". As black does not cooperate with autopep on some style options let's expand the default --disable-lint options in our inspektor and rely on black. Signed-off-by: Lukáš Doktor <[email protected]>
|
@pevogam this should take care of black ;-) |
pevogam
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice @ldoktor! I think this will make for a great improvement in readability before a potential release.
Well it's (more-less) their work. Anyway I'll have to get used to the: notation which I do not enjoy... |
Actually this notation is much more flexible when it comes to renames. Just imagine you rename a function changing the number of characters it contains and as a result having to change all follow us tabulation to align it again (something which is also not that simple hard to automate). Now you will only have to change one and the actual line for a rename like this. |
|
Sure, I'm not saying it's bad, it's just something I need to get used to :-) |
This PR is built on top of #151 and adds python black style fixes.