Skip to content

Conversation

@pevogam
Copy link
Contributor

@pevogam pevogam commented May 21, 2025

This standardizes the string quote use and fixes some missed fstrings, then also formats some line lengths and other small changes.

@pevogam pevogam force-pushed the ops-black-lint branch 2 times, most recently from 6444292 to 82786f5 Compare May 21, 2025 06:26
Copy link
Contributor

@ldoktor ldoktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you please change the "foo" if XX else " to if/then/else? Apart from that it's fine, but perhaps we should include the black check in make check, what do you think?

@pevogam
Copy link
Contributor Author

pevogam commented May 23, 2025

Would you please change the "foo" if XX else " to if/then/else? Apart from that it's fine, but perhaps we should include the black check in make check, what do you think?

I actually thought black is already applied to the code base and perhaps missed in these modules. If we add it to make check this will need a complete pass over the code base then? If so we better do so in a separate pull request to merge after some of the currently open ones to avoid conflicts and the like.

pevogam added 2 commits May 23, 2025 15:11
This standardizes the string quote use and fixes some missed fstrings,
then also formats some line lengths and other small changes.

Signed-off-by: Plamen Dimitrov <[email protected]>
This is similar to the way it was done for the general remote
module and other locations within the aexpect codebase.

Signed-off-by: Plamen Dimitrov <[email protected]>
Copy link
Contributor

@ldoktor ldoktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, it's an improvement and let me add the black for all modules in following pr.

@ldoktor ldoktor merged commit a006476 into avocado-framework:main May 26, 2025
3 checks passed
@pevogam pevogam deleted the ops-black-lint branch June 12, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants