-
Notifications
You must be signed in to change notification settings - Fork 34
Pass both ops linux/windows modules through black linting #150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6444292 to
82786f5
Compare
ldoktor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you please change the "foo" if XX else " to if/then/else? Apart from that it's fine, but perhaps we should include the black check in make check, what do you think?
I actually thought black is already applied to the code base and perhaps missed in these modules. If we add it to |
This standardizes the string quote use and fixes some missed fstrings, then also formats some line lengths and other small changes. Signed-off-by: Plamen Dimitrov <[email protected]>
This is similar to the way it was done for the general remote module and other locations within the aexpect codebase. Signed-off-by: Plamen Dimitrov <[email protected]>
ldoktor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, it's an improvement and let me add the black for all modules in following pr.
This standardizes the string quote use and fixes some missed fstrings, then also formats some line lengths and other small changes.