fix: Properly cast RangeExpression#286
Merged
metthal merged 2 commits intoavast:masterfrom Jan 14, 2026
Merged
Conversation
metthal
approved these changes
Jan 14, 2026
| auto symbol = std::make_shared<ValueSymbol>(args[2].getTokenIt()->getString(), !iterSet->getElements().empty() ? iterSet->getElements()[0]->getType() : Expression::Type::Int); | ||
| // for_expression_set can be either SetExpression (enumeration) or RangeExpression (range) | ||
| auto iterType = Expression::Type::Int; | ||
| if (auto iterSet = std::dynamic_pointer_cast<const SetExpression>(args[4].getExpression())) |
Member
There was a problem hiding this comment.
I'd just use as<T> instead of dynamic pointer cast directly since we are using as in other places already.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: The YARA parser crashed when using a
for ... inloop with an integer range expression like (0 .. 0x1500).Root cause: The code in
parser_driver.cppassumed thatfor_expression_setwas always aSetExpressionand usedstatic_pointer_castto cast it. However, it can also be aRangeExpression(e.g., (0 .. 0x1500)), which caused the cast to fail.Fix:
static_pointer_casttodynamic_pointer_castSetExpression, derive the iterator type from the first element; if it's aRangeExpression, default toInttype (since ranges are always over integers)