Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #152 +/- ##
=======================================
Coverage 91.70% 91.70%
=======================================
Files 2 2
Lines 217 217
=======================================
Hits 199 199
Misses 12 12
Partials 6 6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Updates library documentation to reflect the API migration from package-level DoWithData to the typed NewWithData[T]().Do(...) pattern, with clearer migration notes and Go 1.20 error-wrapping behavior.
Changes:
- Update “HTTP GET with retry with data” examples to the new
NewWithData[T]().Do(...)usage. - Add explicit migration notes for both
DoandDoWithDatatransitions. - Clarify error-wrapping behavior (
Unwrap()returning[]error) for Go 1.20.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| retry.go | Updates GoDoc examples and migration bullet list to the new NewWithData[T]().Do(...) API. |
| README.md | Mirrors the same example and migration documentation updates for end users. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Change `DoWithData` to a method: `retry.DoWithData(func, opts...)` → `retry.NewWithData[T](opts...).Do(func)` - Improve clarity in migration instructions and API simplification details. - Explain enhancements in performance and error handling with Go 1.20 support.
JaSei
force-pushed
the
v5_braking_changes_doc
branch
from
6ddef53 to
f631687
Compare
- Extend GitHub Actions workflow to include Go 1.26 - Revise README and code comments for clarity on method transitions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DoWithDatato a method:retry.DoWithData(func, opts...)→retry.NewWithData[T](opts...).Do(func)