Skip to content

Make the plugin.Services class available at the base module level for easier typing#119

Merged
augi merged 1 commit intoavast:masterfrom
jenstroeger:hoist-services-class
Apr 7, 2025
Merged

Make the plugin.Services class available at the base module level for easier typing#119
augi merged 1 commit intoavast:masterfrom
jenstroeger:hoist-services-class

Conversation

@jenstroeger
Copy link
Contributor

Hello, thank you for this plugin! One minor issue with using typed code on my end is that I have to use

def test_function(docker_services: pytest_docker.plugin.Services) -> None:
    ...

because the Services class itself wasn’t imported into the main module. This change adds the class name which should make typing a little easier…

@augi augi requested a review from Copilot April 7, 2025 10:10
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@augi augi merged commit e566915 into avast:master Apr 7, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants