Address the UI/UX feedback on the universal-components SDK by pmathew92 · Pull Request #15 · auth0/ui-components-android

pmathew92 · 2026-04-06T10:40:38Z

Description

This PR addressed feedbacks shared by the UI/UX team on the SDK .

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation update
Code refactoring
Performance improvement
Test improvement

Testing

Unit tests
Manual testing
Sample app testing

Checklist

I have read the Auth0 general contribution guidelines
I have read the Auth0 Code of Conduct
All existing and new tests complete without errors

Copilot

Pull request overview

This PR updates the universal-components SDK UI flows based on UI/UX feedback, including improved MFA email enrollment UX (email prefill), passkey error recovery UX, and some internal refactoring/cleanup.

Changes:

Add a UserInfo model + UserRepository + GetUserInfoUseCase, and use it to prefill email during EMAIL authenticator enrollment.
Improve passkey UX by allowing the UI to reset passkey state from an error and show back navigation only in that case.
Refactor DI wiring from MyAccountModule to UniversalComponentsModule, plus small UI import cleanups and authenticator method handling tweaks (dedup factors, email display fix).

Reviewed changes

Copilot reviewed 28 out of 28 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
universal_components/src/test/java/com/auth0/universalcomponents/TestData.kt	Adds `UserInfo` test fixtures for new prefill-related tests.
universal_components/src/test/java/com/auth0/universalcomponents/presentation/viewmodel/PasskeyViewModelTest.kt	Adds coverage for the new `resetState()` behavior.
universal_components/src/test/java/com/auth0/universalcomponents/presentation/viewmodel/EnrollmentViewModelTest.kt	Updates VM construction for new dependency and adds EMAIL prefill tests.
universal_components/src/test/java/com/auth0/universalcomponents/domain/usecase/GetUserInfoUseCaseTest.kt	New unit tests for `GetUserInfoUseCase` result mapping.
universal_components/src/test/java/com/auth0/universalcomponents/domain/usecase/GetEnabledAuthenticatorMethodsUseCaseTest.kt	Adds tests validating factor de-duplication behavior.
universal_components/src/test/java/com/auth0/universalcomponents/data/repository/UserRepositoryImplTest.kt	New tests for mapping credentials user profile into `UserInfo`.
universal_components/src/main/java/com/auth0/universalcomponents/presentation/viewmodel/EnrollmentViewModel.kt	Adds `prefillEmail` to state and triggers prefill for EMAIL authenticator type.
universal_components/src/main/java/com/auth0/universalcomponents/presentation/ui/passkeys/PasskeyViewModel.kt	Adds `resetState()` API to return UI to Idle after errors.
universal_components/src/main/java/com/auth0/universalcomponents/presentation/ui/passkeys/PasskeyEnableScreen.kt	Removes unused typography imports.
universal_components/src/main/java/com/auth0/universalcomponents/presentation/ui/mfa/RecoveryCodeEnrollmentScreen.kt	Switches DI factory provider to `UniversalComponentsModule`.
universal_components/src/main/java/com/auth0/universalcomponents/presentation/ui/mfa/QREnrollmentScreen.kt	Switches DI factory provider to `UniversalComponentsModule`.
universal_components/src/main/java/com/auth0/universalcomponents/presentation/ui/mfa/phone/PhoneEnrollmentScreen.kt	Switches DI factory provider to `UniversalComponentsModule`.
universal_components/src/main/java/com/auth0/universalcomponents/presentation/ui/mfa/OTPVerificationScreen.kt	Switches DI factory provider to `UniversalComponentsModule` and removes unused import.
universal_components/src/main/java/com/auth0/universalcomponents/presentation/ui/mfa/EnrolledAuthenticatorListScreen.kt	Switches DI factory providers to `UniversalComponentsModule` and removes unused import.
universal_components/src/main/java/com/auth0/universalcomponents/presentation/ui/mfa/EmailEnrollmentScreen.kt	Adds `LaunchedEffect` to prefill the email input from VM state and switches DI module.
universal_components/src/main/java/com/auth0/universalcomponents/presentation/ui/mfa/AuthenticatorMethodsScreen.kt	Updates top bar back navigation behavior for passkey error recovery and switches DI module.
universal_components/src/main/java/com/auth0/universalcomponents/presentation/ui/components/SnackBar.kt	Removes unused import.
universal_components/src/main/java/com/auth0/universalcomponents/presentation/ui/components/ErrorScreen.kt	Removes unused typography imports.
universal_components/src/main/java/com/auth0/universalcomponents/domain/usecase/GetUserInfoUseCase.kt	Introduces new use case to retrieve identity info from session credentials.
universal_components/src/main/java/com/auth0/universalcomponents/domain/usecase/GetEnrolledAuthenticatorsUseCase.kt	Fixes email enrolled authenticator display mapping to use `email` instead of `name`.
universal_components/src/main/java/com/auth0/universalcomponents/domain/usecase/GetEnabledAuthenticatorMethodsUseCase.kt	De-duplicates factor list by type when building secondary authenticator list.
universal_components/src/main/java/com/auth0/universalcomponents/domain/repository/UserRepository.kt	New repository abstraction for retrieving user identity from credentials.
universal_components/src/main/java/com/auth0/universalcomponents/domain/repository/MyAccountRepository.kt	Adds `updateAuthenticationMethodName` API to the repository contract.
universal_components/src/main/java/com/auth0/universalcomponents/domain/model/UserInfo.kt	New domain model for user identity info used for UI prefill.
universal_components/src/main/java/com/auth0/universalcomponents/di/viewmodelfactory/EnrollmentViewModelFactory.kt	Wires `GetUserInfoUseCase` into `EnrollmentViewModel`.
universal_components/src/main/java/com/auth0/universalcomponents/di/UniversalComponentsModule.kt	Renames/expands DI module to provide `UserRepository` + `GetUserInfoUseCase` and updated factories.
universal_components/src/main/java/com/auth0/universalcomponents/data/repository/UserRepositoryImpl.kt	Implements `UserRepository` by mapping Auth0 credentials user profile to `UserInfo`.
universal_components/src/main/java/com/auth0/universalcomponents/data/repository/MyAccountRepositoryImpl.kt	Adds `updateAuthenticationMethodName` method stub (currently TODO).

Comments suppressed due to low confidence (1)

universal_components/src/main/java/com/auth0/universalcomponents/di/UniversalComponentsModule.kt:25

Renaming/removing MyAccountModule in favor of UniversalComponentsModule is a breaking API change for any SDK consumers that referenced com.auth0.universalcomponents.di.MyAccountModule. If this module is intended to be public, consider keeping a deprecated MyAccountModule wrapper/alias that forwards to UniversalComponentsModule to preserve source compatibility (or document this as a breaking change).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-06T10:44:44Z

...nents/src/main/java/com/auth0/universalcomponents/data/repository/MyAccountRepositoryImpl.kt

+                scope = scope
+            )
+            val client = myAccountProvider.getMyAccount(accessToken)
+            TODO("Not yet implemented")


updateAuthenticationMethodName is part of the MyAccountRepository contract but the implementation currently ends with TODO("Not yet implemented"), which will throw at runtime if invoked. Either implement the call against the MyAccount client (and add tests), or remove this method from the interface/PR until it is supported.

Suggested change

TODO("Not yet implemented")

client.updateAuthenticationMethodName(authenticationMethodId, name).await()

Intentional. this will be updated later

@pmathew92 valid point!

Copilot · 2026-04-06T10:44:44Z

..._components/src/main/java/com/auth0/universalcomponents/domain/usecase/GetUserInfoUseCase.kt

+import com.auth0.universalcomponents.domain.DispatcherProvider
+import com.auth0.universalcomponents.domain.error.Auth0Error
+import com.auth0.universalcomponents.domain.model.UserInfo
+import com.auth0.universalcomponents.domain.network.Result
+import com.auth0.universalcomponents.domain.network.safeCall
+import com.auth0.universalcomponents.domain.repository.UserRepository
+
+/**
+ * UseCase that retrieves identity information about the currently authenticated user
+ * from session credentials.
+ */
+class GetUserInfoUseCase(
+    private val userRepository: UserRepository,
+) {
+    suspend operator fun invoke(): Result<UserInfo, Auth0Error> =
+        safeCall {
+            userRepository.getUserInfo()
+        }


getUserInfoUseCase() is called from the ViewModel, but this use case does not switch to an IO dispatcher (unlike the other use cases in this module). Since TokenProvider.fetchCredentials() can involve disk/network work, this can run on the Main thread and cause jank. Consider injecting DispatcherProvider and wrapping the repository call in withContext(dispatcherProvider.io); also remove the currently unused DispatcherProvider import.

Intentional . The underlying SDK handles the threading in this scenario

Or could make it async and show loader reading the message: "Fetching user..."

This is already async .

@pmathew92 let's add a note that the threading handling is already done!

Not required IMO. I am planning to remove this for all use cases so this will be consistent

Copilot · 2026-04-06T10:44:44Z

...components/src/main/java/com/auth0/universalcomponents/data/repository/UserRepositoryImpl.kt

+    override suspend fun getUserInfo(): UserInfo {
+        val user = tokenProvider.fetchCredentials().user
+        return UserInfo(
+            email = user.email,
+            name = user.name,
+            pictureUrl = user.pictureURL
+        )


tokenProvider.fetchCredentials().user is a platform type and can be null at runtime depending on available scopes/claims. Accessing user.email/name/pictureURL without a null-check can crash during email prefill. Consider handling a null user by returning UserInfo(null, null, null) (or throwing a domain error) instead of assuming it is always present.

Is null handling done inside UserInfo, but ideally UserInfo object shouldn't be created if the critical properties are null hence can change the function signature or make it fail-able.

The Credential's will always return a 'User' instance and is a non-nullable type. The properties are defined as null here because the underlying SDK properties are defined as null. The current use case is very small / minimal and the prsent handling should suffice for now

Got it but shouldn't it not return a User instance if all the underlying properties are null

Email will always be present . So a scenario of all properties being null is not possible

Copilot · 2026-04-06T10:44:45Z

...ts/src/main/java/com/auth0/universalcomponents/presentation/viewmodel/EnrollmentViewModel.kt

+        viewModelScope.launch {
+            getUserInfoUseCase()
+                .onSuccess { userInfo ->
+                    Log.d(TAG, "Received email ${userInfo.email}: ")


This log statement includes the user's email address, which is personally identifiable information and can end up in device logs. Prefer logging a non-PII message (or removing the log), e.g., just that prefill succeeded, without interpolating userInfo.email.

Suggested change

Log.d(TAG, "Received email ${userInfo.email}: ")

Log.d(TAG, "Email prefill succeeded")

Very critical. For the safe side always prefer to use dev logs or otherwise too, let's make it a practice to not include user info (classified or not) in logs (after raising the PR).

This is already a debug log and won't be published in release

Sudhanshu96 · 2026-04-07T07:40:35Z

universal_components/src/main/java/com/auth0/universalcomponents/domain/model/UserInfo.kt

+ * derived from the session credentials.
+ */
+data class UserInfo(
+    val email: String?,


Shouldn't we make email non empty. Without any primary key no point in creating a model. Cannot make it hashable otherwise.

Depends upon the use case. The underlying SDK property is null . so making this non null will throw a compilation error. Regarding hashability, null properties are used for hashing in Kotlin

Sudhanshu96

LGTM

pmathew92 added 7 commits April 2, 2026 22:10

Displaying email id in the enrolled authenticators list

20d9869

Cleaned up ununsed imports

2b26b15

Added placeholder API to update the name of an authenticator

21f5301

Added support to prefill email in the email enrollment flow

cbde8ca

Updated test cases for the email prefill

9fd2a49

Addded back buttong to passkey enrollment error screen

3b33503

Removed duplicate factors coming in the list

11bcb8d

Copilot AI review requested due to automatic review settings April 6, 2026 10:40

pmathew92 requested a review from a team as a code owner April 6, 2026 10:40

Copilot started reviewing on behalf of pmathew92 April 6, 2026 10:41 View session

Copilot AI reviewed Apr 6, 2026

View reviewed changes

pmathew92 added 3 commits April 6, 2026 16:29

Addressed review comments

902dd63

Removed the unused update API

ea11798

Minor refactor

c1695b5

Sudhanshu96 previously approved these changes Apr 7, 2026

View reviewed changes

Handling error in the user repository

9f059d0

pmathew92 dismissed Sudhanshu96’s stale review via 9f059d0 April 7, 2026 09:35

Sudhanshu96 approved these changes Apr 7, 2026

View reviewed changes

pmathew92 merged commit 2b7e06c into main Apr 7, 2026
4 checks passed

	TODO("Not yet implemented")
	client.updateAuthenticationMethodName(authenticationMethodId, name).await()

	Log.d(TAG, "Received email ${userInfo.email}: ")
	Log.d(TAG, "Email prefill succeeded")

Conversation

pmathew92 commented Apr 6, 2026

Description

Type of Change

Testing

Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Sudhanshu96 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants