Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Android sample app UI to better match recent design feedback, including new background treatments, selectable sign-in cards, and some theme-aware styling adjustments. It also refactors parts of the GitHub Actions release/SCA workflows.
Changes:
- Introduces a reusable Compose screen background modifier with light/dark variants and overlay gradients.
- Updates multiple screens/components (Choose Sign In, Dashboard, Embedded Login, logo header, cards) to align with the new UI and selection behavior.
- Enhances release automation by adding composite actions (version parsing, prerelease detection, tag existence check, release creation) and adjusts workflow triggers.
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| app/src/main/java/com/auth0/android/sample/ui/viewmodels/AuthViewModel.kt | Adjusts login cancellation/browser-not-available logging behavior. |
| app/src/main/java/com/auth0/android/sample/ui/theme/Color.kt | Defines updated light/dark background brushes and radial overlays. |
| app/src/main/java/com/auth0/android/sample/ui/theme/BackgroundModifier.kt | Adds auth0ScreenBackground() modifier to apply the new backgrounds. |
| app/src/main/java/com/auth0/android/sample/ui/screens/ExploreLoginScreen.kt | Switches screen background usage to the new modifier. |
| app/src/main/java/com/auth0/android/sample/ui/screens/EmbeddedLoginScreen.kt | Applies new background, adds status bar padding + back button, tweaks text field colors. |
| app/src/main/java/com/auth0/android/sample/ui/screens/DashboardScreen.kt | Applies new background and adjusts grid/logout spacing/layout. |
| app/src/main/java/com/auth0/android/sample/ui/screens/ChooseSignInScreen.kt | Adds selectable cards + disabled-until-selected Continue button; pins Appearance CTA to bottom. |
| app/src/main/java/com/auth0/android/sample/ui/screens/AppearanceScreen.kt | Wraps content in a local Auth0Theme for immediate preview + dark-aware radio selection color. |
| app/src/main/java/com/auth0/android/sample/ui/components/NavigationGridCard.kt | Tweaks border and elevation to match updated styling. |
| app/src/main/java/com/auth0/android/sample/ui/components/FactorCard.kt | Adds selectable styling + radio indicator; updates click handling to Card onClick. |
| app/src/main/java/com/auth0/android/sample/ui/components/Auth0LogoHeader.kt | Tints logo in dark mode for visibility. |
| .github/workflows/sca_scan.yml | Changes SCA workflow trigger to PRs on main. |
| .github/workflows/release.yml | Adds manual dispatch, adds composite steps, switches runner, adds tag-exists guard, and GitHub release creation. |
| .github/actions/tag-exists/action.yml | New composite action to check if a git tag exists via GitHub API. |
| .github/actions/release-create/action.yml | New composite action to create a GitHub release (softprops/action-gh-release). |
| .github/actions/maven-publish/action.yml | Simplifies publish action (relies on shared setup for Java/Gradle) and normalizes env formatting. |
| .github/actions/get-version/action.yml | New composite action to read the version from .version. |
| .github/actions/get-release-notes/action.yml | New composite action to pull release notes from the release PR body. |
| .github/actions/get-prerelease/action.yml | New composite action to detect prerelease versions (alpha/beta). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
app/src/main/java/com/auth0/android/sample/ui/viewmodels/AuthViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/auth0/android/sample/ui/theme/BackgroundModifier.kt
Show resolved
Hide resolved
| fun Modifier.auth0ScreenBackground(): Modifier { | ||
| val colors = Auth0Theme.colors | ||
| val isDark = colors.backgroundLayerBase.red < 0.1f |
There was a problem hiding this comment.
Theme detection via colors.backgroundLayerBase.red < 0.1f is duplicated across multiple UI files and is brittle if the token changes. Consider centralizing this into a single helper (e.g., @Composable fun isAuth0DarkTheme(): Boolean) or exposing an explicit dark-mode flag from the theme so future token adjustments don't break behavior.
| fun Modifier.auth0ScreenBackground(): Modifier { | |
| val colors = Auth0Theme.colors | |
| val isDark = colors.backgroundLayerBase.red < 0.1f | |
| fun isAuth0DarkTheme(): Boolean { | |
| val colors = Auth0Theme.colors | |
| return colors.backgroundLayerBase.red < 0.1f | |
| } | |
| @Composable | |
| fun Modifier.auth0ScreenBackground(): Modifier { | |
| val isDark = isAuth0DarkTheme() |
Description
This PR updates the sample app UI as per the design feedback
Screenshots (if appropriate)
sample_app.mp4
Checklist
I have read the Auth0 general contribution guidelines
I have read the Auth0 Code of Conduct
All existing and new tests complete without errors