Skip to content

refactor : Made the updateAuthenticationMethodById public#948

Merged
pmathew92 merged 3 commits intomainfrom
my_account_update_public
Apr 6, 2026
Merged

refactor : Made the updateAuthenticationMethodById public#948
pmathew92 merged 3 commits intomainfrom
my_account_update_public

Conversation

@pmathew92
Copy link
Copy Markdown
Contributor

Changes

This PR makes updateAuthenticationMethodById in the MyAccountAPIClient class public. This API was earlier markes as internal which made in impossible for consuming clients to use this API

Checklist

@pmathew92 pmathew92 requested a review from a team as a code owner April 6, 2026 07:32
Copilot AI review requested due to automatic review settings April 6, 2026 07:32
utkrishtsahu
utkrishtsahu previously approved these changes Apr 6, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR exposes MyAccountAPIClient.updateAuthenticationMethodById as a public API so consuming applications can update an authentication method via the My Account API.

Changes:

  • Changed updateAuthenticationMethodById visibility from internal to public in MyAccountAPIClient.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

subhankarmaiti
subhankarmaiti previously approved these changes Apr 6, 2026
@pmathew92 pmathew92 dismissed stale reviews from subhankarmaiti and utkrishtsahu via 4e79a9e April 6, 2026 07:38
@NandanPrabhu
Copy link
Copy Markdown
Contributor

do we need to update examples.md or readme.md for the same?

@pmathew92
Copy link
Copy Markdown
Contributor Author

pmathew92 commented Apr 6, 2026

do we need to update examples.md or readme.md for the same?

Good catch. Looks like example for this was not added. Have updated the same

@pmathew92 pmathew92 merged commit 5c371a5 into main Apr 6, 2026
6 checks passed
@pmathew92 pmathew92 deleted the my_account_update_public branch April 6, 2026 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants